linux-kernel - Re: [PATCH v4 1/2] uio_hv_generic: Fix sysfs creation path for ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025041556-disburse-tiling-8e72@gregkh>
Date: Tue, 15 Apr 2025 18:13:44 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Naman Jain <namjain@...ux.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, Saurabh Sengar <ssengar@...ux.microsoft.com>,
	Michael Kelley <mhklinux@...look.com>
Subject: Re: [PATCH v4 1/2] uio_hv_generic: Fix sysfs creation path for ring
 buffer

On Thu, Apr 10, 2025 at 11:38:46AM +0530, Naman Jain wrote:
> +	/*
> +	 * Skip updating the sysfs group if the primary channel is not yet initialized and sysfs
> +	 * group is not yet created. In those cases, the 'ring' will be created later in
> +	 * vmbus_device_register() -> vmbus_add_channel_kobj().
> +	 */
> +	if  (!primary_channel->device_obj->channels_kset)
> +		return 0;

2 spaces after "if"?

Yeah, it's minor, but it made me think that checkpatch had not been run.

thanks,

greg k-h