linux-kernel - Re: [PATCH v3] loop: LOOP_SET_FD: send uevents for partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2wzcj4odajfsvubribqetasj26pp5u3wnusnowwwjiwy4lj5p5@vpa7vwwseyq2>
Date: Tue, 15 Apr 2025 18:42:42 +0200
From: Jan Kara <jack@...e.cz>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Jens Axboe <axboe@...nel.dk>, Martijn Coenen <maco@...roid.com>, 
	Alyssa Ross <hi@...ssa.is>, Christoph Hellwig <hch@....de>, Greg KH <greg@...ah.com>, 
	Jan Kara <jack@...e.cz>, John Ogness <john.ogness@...utronix.de>, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] loop: LOOP_SET_FD: send uevents for partitions

On Tue 15-04-25 16:55:06, Thomas Weißschuh wrote:
> Remove the suppression of the uevents before scanning for partitions.
> The partitions inherit their suppression settings from their parent device,
> which lead to the uevents being dropped.
> 
> This is similar to the same changes for LOOP_CONFIGURE done in
> commit bb430b694226 ("loop: LOOP_CONFIGURE: send uevents for partitions").
> 
> Fixes: 498ef5c777d9 ("loop: suppress uevents while reconfiguring the device")
> Cc: stable@...r.kernel.org
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
> Changes in v3:
> - Rebase onto block/block-6.15
> - Drop already applied patch "loop: properly send KOBJ_CHANGED uevent for disk device"
> - Add patch to fix partition uevents for LOOP_SET_FD
> - Link to v2: https://lore.kernel.org/r/20250415-loop-uevent-changed-v2-1-0c4e6a923b2a@linutronix.de
> 
> Changes in v2:
> - Use correct Fixes tag
> - Rework commit message slightly
> - Rebase onto v6.15-rc1
> - Link to v1: https://lore.kernel.org/r/20250317-loop-uevent-changed-v1-1-cb29cb91b62d@linutronix.de
> ---
>  drivers/block/loop.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 3be7f00e7fc740da2745ffbccfcebe53eef2ddaa..e9ec7a45f3f2d1dd2a82b3506f3740089a20ae05 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -662,12 +662,12 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
>  	 * dependency.
>  	 */
>  	fput(old_file);
> +	dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 0);
>  	if (partscan)
>  		loop_reread_partitions(lo);
>  
>  	error = 0;
>  done:
> -	dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 0);
>  	kobject_uevent(&disk_to_dev(lo->lo_disk)->kobj, KOBJ_CHANGE);
>  	return error;
>  
> @@ -675,6 +675,7 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
>  	loop_global_unlock(lo, is_loop);
>  out_putf:
>  	fput(file);
> +	dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 0);
>  	goto done;
>  }
>  
> 
> ---
> base-commit: 7ed2a771b5fb3edee9c4608181235c30b40bb042
> change-id: 20250307-loop-uevent-changed-aa3690f43e03
> 
> Best regards,
> -- 
> Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR