linux-kernel - Re: [PATCH 02/17] scsi: bfa: Rename 'timer_mod' to 'timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250415185004.4bf93486@pumpkin>
Date: Tue, 15 Apr 2025 18:50:04 +0100
From: David Laight <david.laight.linux@...il.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
 Frederic Weisbecker <frederic@...nel.org>, "H . Peter Anvin"
 <hpa@...or.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Peter
 Zijlstra <peterz@...radead.org>, Anil Gurumurthy
 <anil.gurumurthy@...gic.com>, "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
 <martin.petersen@...cle.com>, Sudarsana Kalluru
 <sudarsana.kalluru@...gic.com>
Subject: Re: [PATCH 02/17] scsi: bfa: Rename 'timer_mod' to 'timer_module'

On Mon, 14 Apr 2025 12:22:36 +0200
Ingo Molnar <mingo@...nel.org> wrote:

> We'd like to introduce timer_mod() in the kernel, so make
> sure the namespace is clear.

You global edit didn't work.
Even the first two changes are broken.

...
> -	use_idlect1 = omap_dm_timer_modify_idlect_mask(use_idlect1);
> +	use_idlect1 = omap_dm_timer_moduleify_idlect_mask(use_idlect1);
...
> -void __init s3c64xx_set_timer_source(enum s3c64xx_timer_mode event,
> -				     enum s3c64xx_timer_mode source)
> +void __init s3c64xx_set_timer_source(enum s3c64xx_timer_modulee event,
> +				     enum s3c64xx_timer_modulee source)

Most of the changes seem to be wrong.

	David