linux-kernel - Re: [PATCH] btrfs: Fix the incorrect description in comments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250415180058.GM16750@twin.jikos.cz>
Date: Tue, 15 Apr 2025 20:00:58 +0200
From: David Sterba <dsterba@...e.cz>
To: Charles Han <hanchunchao@...pur.com>
Cc: clm@...com, josef@...icpanda.com, dsterba@...e.com,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fix the incorrect description in comments.

On Thu, Apr 10, 2025 at 05:07:22PM +0800, Charles Han wrote:
> Replace PTR_ERR(-ENOMEM) to ERR_PTR(-ENOMEM) in comments.
> 
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>  fs/btrfs/delayed-inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index 3f1551d8a5c6..e35626270f2b 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -119,7 +119,7 @@ static struct btrfs_delayed_node *btrfs_get_delayed_node(
>  	return NULL;
>  }
>  
> -/* Will return either the node or PTR_ERR(-ENOMEM) */
> +/* Will return either the node or ERR_PTR(-ENOMEM) */

Thanks, while this is correct it would be better to update the whole
function comment so it's more descriptive. I'll write someting when
adding the patch to for-next, thanks.