linux-kernel - Re: [PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250415184448.GF395307@horms.kernel.org>
Date: Tue, 15 Apr 2025 19:44:48 +0100
From: Simon Horman <horms@...nel.org>
To: Sathesh B Edara <sedara@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, hgani@...vell.com,
	vimleshk@...vell.com, Veerasenareddy Burru <vburru@...vell.com>,
	Shinas Rasheed <srasheed@...vell.com>,
	Satananda Burla <sburla@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v2] octeon_ep_vf: Resolve netdevice usage count issue

On Mon, Apr 14, 2025 at 02:18:55AM -0700, Sathesh B Edara wrote:
> Address the netdevice usage count problem in the following scenarios:
> - When the interface is down
> - During transmit queue timeouts

Hi Sathesh,

I think it would be useful to include a bit more information in
the commit message describing:

1. Why these references were added / why they are not needed there
2. Why this can lead to incorrect reference counts end up being incorrect
   in the two scenarios you mention above

Thanks!

> 
> Fixes: cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization")
> Signed-off-by: Sathesh B Edara <sedara@...vell.com>

...

-- 
pw-bot: changes-requested