linux-kernel - Re: [PATCH iwl-next 14/14] ixd: add devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d397e5c5-e05b-4ec3-bbd6-14f06b33db49@intel.com>
Date: Tue, 15 Apr 2025 11:54:41 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet
	<corbet@....net>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, Jiri Pirko
	<jiri@...nulli.us>, Mustafa Ismail <mustafa.ismail@...el.com>, "Tatyana
 Nikolova" <tatyana.e.nikolova@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, Alexander Lobakin <aleksander.lobakin@...el.com>,
	Michael Ellerman <mpe@...erman.id.au>, Maciej Fijalkowski
	<maciej.fijalkowski@...el.com>, "Lee Trager" <lee@...ger.us>, Madhavan
 Srinivasan <maddy@...ux.ibm.com>, "Sridhar Samudrala"
	<sridhar.samudrala@...el.com>, Jacob Keller <jacob.e.keller@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, Mateusz Polchlopek
	<mateusz.polchlopek@...el.com>, Wenjun Wu <wenjun1.wu@...el.com>, Ahmed Zaki
	<ahmed.zaki@...el.com>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, Emil Tantilov
	<emil.s.tantilov@...el.com>, Madhu Chittim <madhu.chittim@...el.com>, "Josh
 Hay" <joshua.a.hay@...el.com>, Milena Olech <milena.olech@...el.com>,
	<pavan.kumar.linga@...el.com>, "Singhai, Anjali" <anjali.singhai@...el.com>
Subject: Re: [PATCH iwl-next 14/14] ixd: add devlink support



On 4/8/2025 5:48 AM, Larysa Zaremba wrote:
> From: Amritha Nambiar <amritha.nambiar@...el.com>
> 
> Enable initial support for the devlink interface with the ixd
> driver. The ixd hardware is a single function PCIe device. So, the
> PCIe adapter gets its own devlink instance to manage device-wide
> resources or configuration.
> 
> $ devlink dev show
> pci/0000:83:00.6
> 
> $ devlink dev info pci/0000:83:00.6
> pci/0000:83:00.6:
>    driver ixd
>    serial_number 00-a0-c9-ff-ff-23-45-67
>    versions:
>        fixed:
>          device.type MEV
>        running:
>          cp 0.0
>          virtchnl 2.0
> 
> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> ---
>   Documentation/networking/devlink/ixd.rst     |  35 +++++++
>   drivers/net/ethernet/intel/ixd/Kconfig       |   1 +
>   drivers/net/ethernet/intel/ixd/Makefile      |   1 +
>   drivers/net/ethernet/intel/ixd/ixd_devlink.c | 105 +++++++++++++++++++
>   drivers/net/ethernet/intel/ixd/ixd_devlink.h |  44 ++++++++
>   drivers/net/ethernet/intel/ixd/ixd_main.c    |  13 ++-
>   6 files changed, 196 insertions(+), 3 deletions(-)
>   create mode 100644 Documentation/networking/devlink/ixd.rst
>   create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.c
>   create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.h
> 
> diff --git a/Documentation/networking/devlink/ixd.rst b/Documentation/networking/devlink/ixd.rst
> new file mode 100644
> index 000000000000..81b28ffb00f6
> --- /dev/null
> +++ b/Documentation/networking/devlink/ixd.rst

The index needs to be updated as well:

Documentation/networking/devlink/ixd.rst: WARNING: document isn't 
included in any toctree

Thanks,
Tony

> @@ -0,0 +1,35 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +===================
> +ixd devlink support
> +===================
> +
> +This document describes the devlink features implemented by the ``ixd``
> +device driver.
> +
> +Info versions