linux-kernel - Re: [PATCH 02/11] vt: move unicode processing to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98528n67-80p0-25p9-o7n6-4r6n707n2p00@syhkavp.arg>
Date: Tue, 15 Apr 2025 15:03:42 -0400 (EDT)
From: Nicolas Pitre <nico@...xnic.net>
To: Jiri Slaby <jirislaby@...nel.org>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] vt: move unicode processing to a separate file

On Mon, 14 Apr 2025, Jiri Slaby wrote:

> On 10. 04. 25, 3:13, Nicolas Pitre wrote:
> > From: Nicolas Pitre <npitre@...libre.com>
> > 
> > This will make it easier to maintain. Also make it depend on
> > CONFIG_CONSOLE_TRANSLATIONS.
> ...
> > --- a/include/linux/consolemap.h
> > +++ b/include/linux/consolemap.h
> ...
> > @@ -57,6 +58,11 @@ static inline int conv_uni_to_8bit(u32 uni)
> >   }
> >   
> >   static inline void console_map_init(void) { }
> > +
> > +static inline bool ucs_is_double_width(uint32_t cp)
> > +{
> > +	return false;
> > +}
> 
> Is this inline necessary? I assume ucs_is_double_width() won't be called
> outside CONFIG_CONSOLE_TRANSLATIONS?

It is, alongside the other functions in this header file.