linux-kernel - Re: [PATCH net-next v5 07/11] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250415195756.GI395307@horms.kernel.org>
Date: Tue, 15 Apr 2025 20:57:56 +0100
From: Simon Horman <horms@...nel.org>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, nm@...com, ssantosh@...nel.org,
	tony@...mide.com, richardcochran@...il.com, glaroque@...libre.com,
	schnelle@...ux.ibm.com, m-karicheri2@...com, s.hauer@...gutronix.de,
	rdunlap@...radead.org, diogo.ivo@...mens.com, basharath@...thit.com,
	jacob.e.keller@...el.com, m-malladi@...com,
	javier.carrasco.cruz@...il.com, afd@...com, s-anna@...com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	pratheesh@...com, prajith@...com, vigneshr@...com, praneeth@...com,
	srk@...com, rogerq@...com, krishna@...thit.com, pmohan@...thit.com,
	mohan@...thit.com
Subject: Re: [PATCH net-next v5 07/11] net: ti: prueth: Adds support for
 network filters for traffic control supported by PRU-ICSS

On Mon, Apr 14, 2025 at 06:32:33PM +0530, Parvathi Pudi wrote:
> From: Roger Quadros <rogerq@...com>
> 
> Driver updates to enable/disable network filters and traffic control
> features supported by the firmware running on PRU-ICSS.
> 
> Control of the following features are now supported:
> 1. Promiscuous mode
> 2. Network Storm prevention
> 3. Multicast filtering and
> 4. VLAN filtering
> 
> Firmware running on PRU-ICSS will go through all these filter checks
> prior to sending the rx packets to the host.
> 
> Ethtool or dev ioctl can be used to enable/disable these features from
> the user space.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Signed-off-by: Andrew F. Davis <afd@...com>
> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>

...

> diff --git a/drivers/net/ethernet/ti/icssm/icssm_prueth_dos.c b/drivers/net/ethernet/ti/icssm/icssm_prueth_dos.c

...

> +static int icssm_emac_configure_clsflower(struct prueth_emac *emac,
> +					  struct flow_cls_offload *cls)
> +{
> +	struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
> +	struct netlink_ext_ack *extack = cls->common.extack;
> +	const struct flow_action_entry *act;
> +	int i;
> +
> +	flow_action_for_each(i, act, &rule->action) {
> +		switch (act->id) {
> +		case FLOW_ACTION_POLICE:
> +			return icssm_emac_flower_parse_policer
> +				(emac, extack, cls,
> +				 act->police.rate_bytes_ps);
> +		default:
> +			NL_SET_ERR_MSG_MOD(extack,
> +					   "Action not supported");
> +			return -EOPNOTSUPP;
> +		}
> +	}
> +	return -EOPNOTSUPP;

nit: This line cannot be reached.
     I think you can just remove it.

     Flagged by Smatch.

> +}

...