linux-kernel - Re: [PATCH v13 01/19] Documentation/x86: Secure Launch kernel documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0c3aa4e-968a-4a13-a689-fcc727622f24@oracle.com>
Date: Tue, 15 Apr 2025 13:44:37 -0700
From: ross.philipson@...cle.com
To: Sean Christopherson <seanjc@...gle.com>
Cc: ALOK TIWARI <alok.a.tiwari@...cle.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-integrity@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-crypto@...r.kernel.org,
        kexec@...ts.infradead.org, linux-efi@...r.kernel.org,
        iommu@...ts.linux.dev, dpsmith@...rtussolutions.com,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        dave.hansen@...ux.intel.com, ardb@...nel.org, mjg59@...f.ucam.org,
        James.Bottomley@...senpartnership.com, peterhuewe@....de,
        jarkko@...nel.org, jgg@...pe.ca, luto@...capital.net,
        nivedita@...m.mit.edu, herbert@...dor.apana.org.au,
        davem@...emloft.net, corbet@....net, ebiederm@...ssion.com,
        dwmw2@...radead.org, baolu.lu@...ux.intel.com,
        kanth.ghatraju@...cle.com, andrew.cooper3@...rix.com,
        trenchboot-devel@...glegroups.com
Subject: Re: [PATCH v13 01/19] Documentation/x86: Secure Launch kernel
 documentation

On 4/11/25 2:32 PM, 'Sean Christopherson' via trenchboot-devel wrote:
> On Fri, Apr 11, 2025, ross.philipson@...cle.com wrote:
>> On 4/10/25 10:50 PM, ALOK TIWARI wrote:
>>>
>>>
>>> On 11-04-2025 02:11, Ross Philipson wrote:
>>>> +
>>>> + - Entry from the dynamic launch jumps to the SL stub.
>>>> + - SL stub fixes up the world on the BSP.
>>>> + - For TXT, SL stub wakes the APs, fixes up their worlds.
>>>> + - For TXT, APs are left halted using MONITOR/MWAIT intructions.
>>>
>>> typo intructions -> instruction
>>
>> Thanks for the review. They are two separate instructions so is this really
>> incorrect?
> 
>  From the peanut gallery, I'd just drop the "instruction(s)" qualifier, i.e.
> 
> 	- For TXT, APs are left halted using MONITOR/MWAIT.
> 
> Pedantically, it's the combination of MONTIOR+MWAIT that puts the CPU into a
> sleep state, not the individual instructions.
> 
> And while I'm picking nits, the documentation is also a bit misleading as the CPU
> isn't halted per se.  I'd go with something like:
> 
> 	- For TXT, APs are left in an optimized (MONITOR/MWAIT) wait state.
> 
Good suggestion, thanks

Ross