linux-kernel - Re: [PATCH] cpufreq/amd-pstate: Move max_perf limiting in amd_pstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e08fab15-3dce-4471-a016-abd6baab9340@amd.com>
Date: Tue, 15 Apr 2025 15:46:30 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Dhananjay Ugwekar <dhananjay.ugwekar@....com>, gautham.shenoy@....com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq/amd-pstate: Move max_perf limiting in
 amd_pstate_update

On 4/15/2025 3:23 AM, Dhananjay Ugwekar wrote:
> Move up the max_perf limiting, so that we clamp the des_perf with the
> updated max_perf.
> 
> Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@....com>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/cpufreq/amd-pstate.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index c54c031939c8..c29840ba3b30 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -554,6 +554,10 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf,
>   	if (!policy)
>   		return;
>   
> +	/* limit the max perf when core performance boost feature is disabled */
> +	if (!cpudata->boost_supported)
> +		max_perf = min_t(u8, perf.nominal_perf, max_perf);
> +
>   	des_perf = clamp_t(u8, des_perf, min_perf, max_perf);
>   
>   	policy->cur = perf_to_freq(perf, cpudata->nominal_freq, des_perf);
> @@ -563,10 +567,6 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf,
>   		des_perf = 0;
>   	}
>   
> -	/* limit the max perf when core performance boost feature is disabled */
> -	if (!cpudata->boost_supported)
> -		max_perf = min_t(u8, perf.nominal_perf, max_perf);
> -
>   	if (trace_amd_pstate_perf_enabled() && amd_pstate_sample(cpudata)) {
>   		trace_amd_pstate_perf(min_perf, des_perf, max_perf, cpudata->freq,
>   			cpudata->cur.mperf, cpudata->cur.aperf, cpudata->cur.tsc,