linux-kernel - Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72m5uoCnhYR=8eHZ12O+D=A+sChAj7ZNTU8vcCTpAhayog@mail.gmail.com>
Date: Tue, 15 Apr 2025 23:13:04 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-um@...ts.infradead.org, richard@....at, anton.ivanov@...bridgegreys.com, 
	johannes@...solutions.net, geert@...ux-m68k.org, logang@...tatee.com, 
	sbates@...thlin.com, dakr@...nel.org, dinguyen@...nel.org, arnd@...db.de
Subject: Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

On Tue, Apr 15, 2025 at 9:14 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> Applied to `rust-fixes` -- thanks everyone!
>
>     [ Reworded for relative paths. - Miguel ]

Also:

    [ Arnd explains [1] that removing the qualifier is the way forward
      (thanks!):

        Rihgt, I tried this last week when it came up first, removing the
        'volatile' annotations in the asm-generic/io.h header and then
        all the ones that caused build regressions on arm/arm64/x86
        randconfig and allmodconfig builds.  This patch is a little
        longer than my original version as I did run into a few
        regressions later.

        As far as I can tell, none of these volatile annotations have
        any actual effect, and most of them date back to ancient kernels
        where this may have been required.

        Leaving it out of the rust interface is clearly the right way,
        and it shouldn't be too hard to upstream the changes below
        when we need to, but I also don't see any priority to send these.
        If anyone wants to help out, I can send them the whole patch.

      I created an issue [2] in case someone wants to help. - Miguel ]

Cheers,
Miguel