linux-kernel - Re: [PATCH] watchdog: exar: Shorten identity name to fit correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0976e69-1643-4b0b-a7a8-0495fb4e5dc6@roeck-us.net>
Date: Tue, 15 Apr 2025 16:19:15 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Kees Cook <kees@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: linux-watchdog@...r.kernel.org, David Müller
 <d.mueller@...oft.ch>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] watchdog: exar: Shorten identity name to fit correctly

On 4/15/25 15:52, Kees Cook wrote:
> The static initializer for struct watchdog_info::identity is too long
> and gets initialized without a trailing NUL byte. Since the length
> of "identity" is part of UAPI and tied to ioctls, just shorten
> the name of the device. Avoids the warning seen with GCC 15's
> -Wunterminated-string-initialization option:
> 
> drivers/watchdog/exar_wdt.c:224:27: warning: initializer-string for array of 'unsigned char' truncates NUL terminator but destination lacks 'nonstring' attribute (33 chars into 32 available) [-Wunterminated-string-initialization]
>    224 |         .identity       = "Exar/MaxLinear XR28V38x Watchdog",
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 81126222bd3a ("watchdog: Exar/MaxLinear XR28V38x driver")
> Signed-off-by: Kees Cook <kees@...nel.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-watchdog@...r.kernel.org
> ---
>   drivers/watchdog/exar_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/exar_wdt.c b/drivers/watchdog/exar_wdt.c
> index 7c61ff343271..c2e3bb08df89 100644
> --- a/drivers/watchdog/exar_wdt.c
> +++ b/drivers/watchdog/exar_wdt.c
> @@ -221,7 +221,7 @@ static const struct watchdog_info exar_wdt_info = {
>   	.options	= WDIOF_KEEPALIVEPING |
>   			  WDIOF_SETTIMEOUT |
>   			  WDIOF_MAGICCLOSE,
> -	.identity	= "Exar/MaxLinear XR28V38x Watchdog",
> +	.identity	= "Exar XR28V38x Watchdog",
>   };
>   
>   static const struct watchdog_ops exar_wdt_ops = {