linux-kernel - Re: [PATCH V3] loop: aio inherit the ioprio of original request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+3AYtRRgL2-vPNm=1XBKd_PFuRcB5fZh96VGsfTO2VaAvqv9w@mail.gmail.com>
Date: Tue, 15 Apr 2025 13:56:44 +0800
From: yunlong xing <yunlongxing23@...il.com>
To: Yunlong Xing <yunlong.xing@...soc.com>
Cc: axboe@...nel.dk, linux-block@...r.kernel.org, bvanassche@....org, 
	hch@....de, niuzhiguo84@...il.com, linux-kernel@...r.kernel.org, 
	hao_hao.wang@...soc.com
Subject: Re: [PATCH V3] loop: aio inherit the ioprio of original request

Yunlong Xing <yunlong.xing@...soc.com> 于2025年4月15日周二 13:45写道：
>
> Set cmd->iocb.ki_ioprio to the ioprio of loop device's request.
> The purpose is to inherit the original request ioprio in the aio
> flow.
>
> Signed-off-by: Yunlong Xing <yunlong.xing@...soc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Link: https://lore.kernel.org/r/20250414030159.501180-1-yunlong.xing@unisoc.com
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> ---
> V3:
> - fix Signed-off-by error in commit message
> ---
> V2:
> - Assign cmd->iocb.ki_ioprio in lo_rw_aio()
> ---
>  drivers/block/loop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 674527d770dc..dd7f33d47f4f 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -447,7 +447,7 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd,
>         cmd->iocb.ki_filp = file;
>         cmd->iocb.ki_complete = lo_rw_aio_complete;
>         cmd->iocb.ki_flags = IOCB_DIRECT;
> -       cmd->iocb.ki_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0);
> +       cmd->iocb.ki_ioprio = req_get_ioprio(rq);
>
>         if (rw == ITER_SOURCE)
>                 ret = file->f_op->write_iter(&cmd->iocb, &iter);
> --
> 2.25.1
>

Hi Jens，

There is a mistake of Signed-off-by in commit message on previous version.
I noticed that you had commited it in block-6.15. Could you please help fix it.

Best regards,