linux-kernel - Re: [PATCH] dt-bindings: phy: rockchip: Convert RK3399 PCIe PHY to schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174467700194.2177524.2394978588221841695.robh@kernel.org>
Date: Mon, 14 Apr 2025 19:30:01 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 devicetree@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, linux-phy@...ts.infradead.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-rockchip@...ts.infradead.org, 
 linux-arm-kernel@...ts.infradead.org, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH] dt-bindings: phy: rockchip: Convert RK3399 PCIe PHY to
 schema


On Mon, 14 Apr 2025 17:53:09 -0500, Rob Herring (Arm) wrote:
> Convert the Rockchip RK3399 PCIe PHY to DT schema format. Move the
> example to the GRF binding as that has the complete block.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../bindings/phy/rockchip-pcie-phy.txt        | 36 -------------------
>  .../devicetree/bindings/soc/rockchip/grf.yaml | 13 +++++--
>  2 files changed, 11 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: syscon@...70000 (rockchip,rk3399-grf): pcie-phy: False schema does not allow {'compatible': ['rockchip,rk3399-pcie-phy'], '#phy-cells': 1, 'clocks': [[4294967295, 138]], 'clock-names': ['refclk'], 'resets': [[4294967295, 135]], 'reset-names': ['phy']}
	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: syscon@...70000 (rockchip,rk3399-grf): pcie-phy: Unevaluated properties are not allowed ('#phy-cells', 'clock-names', 'clocks', 'compatible', 'reset-names', 'resets' were unexpected)
	from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: /example-0/syscon@...70000/pcie-phy: failed to match any schema with compatible: ['rockchip,rk3399-pcie-phy']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250414225311.1913480-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.