linux-kernel - RE: [PATCH] Revert "PCI: Avoid reset when disabled via sysfs"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL1PR11MB527186F68B0F087D7F4B22988CB22@BL1PR11MB5271.namprd11.prod.outlook.com>
Date: Tue, 15 Apr 2025 06:24:18 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Alex Williamson <alex.williamson@...hat.com>, "helgaas@...nel.org"
	<helgaas@...nel.org>
CC: "naravamudan@...dia.com" <naravamudan@...dia.com>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "raphael.norwitz@...anix.com"
	<raphael.norwitz@...anix.com>, "ameynarkhede03@...il.com"
	<ameynarkhede03@...il.com>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jgg@...dia.com" <jgg@...dia.com>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "cp@...olutedigital.net" <cp@...olutedigital.net>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] Revert "PCI: Avoid reset when disabled via sysfs"

> From: Alex Williamson <alex.williamson@...hat.com>
> Sent: Tuesday, April 15, 2025 5:18 AM
> 
> This reverts commit 479380efe1625e251008d24b2810283db60d6fcd.
> 
> The reset_method attribute on a PCI device is only intended to manage
> the availability of function scoped resets for a device.  It was never
> intended to restrict resets targeting the bus or slot.
> 
> In introducing a restriction that each device must support function
> level reset by testing pci_reset_supported(), we essentially create a
> catch-22, that a device must have a function scope reset in order to
> support bus/slot reset, when we use bus/slot reset to effect a reset
> of a device that does not support a function scoped reset, especially
> multi-function devices.
> 
> This breaks the majority of uses cases where vfio-pci uses bus/slot
> resets to manage multifunction devices that do not support function
> scoped resets.
> 
> Fixes: 479380efe162 ("PCI: Avoid reset when disabled via sysfs")
> Reported-by: Cal Peake <cp@...olutedigital.net>
> Link: https://lore.kernel.org/all/808e1111-27b7-f35b-6d5c-
> 5b275e73677b@...olutedigital.net
> Cc: stable@...r.kernel.org
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>