linux-kernel - RE: [PATCH rc] iommu: Fix two issues in iommu_copy_struct_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL1PR11MB5271DA81EC809A7095BC99328CB22@BL1PR11MB5271.namprd11.prod.outlook.com>
Date: Tue, 15 Apr 2025 06:27:34 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>, "joro@...tes.org" <joro@...tes.org>,
	"jgg@...dia.com" <jgg@...dia.com>
CC: "will@...nel.org" <will@...nel.org>, "robin.murphy@....com"
	<robin.murphy@....com>, "Liu, Yi L" <yi.l.liu@...el.com>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mochs@...dia.com" <mochs@...dia.com>, "alok.a.tiwari@...cle.com"
	<alok.a.tiwari@...cle.com>
Subject: RE: [PATCH rc] iommu: Fix two issues in iommu_copy_struct_from_user()

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Tuesday, April 15, 2025 3:17 AM
> 
> In the review for iommu_copy_struct_to_user() helper, Matt pointed out
> that
> a NULL pointer should be rejected prior to dereferencing it:
> https://lore.kernel.org/all/86881827-8E2D-461C-BDA3-
> FA8FD14C343C@...dia.com
> 
> And Alok pointed out a typo at the same time:
> https://lore.kernel.org/all/480536af-6830-43ce-a327-
> adbd13dc3f1d@...cle.com
> 
> Since both issues were copied from iommu_copy_struct_from_user(), fix
> them
> first in the current header.
> 
> Fixes: e9d36c07bb78 ("iommu: Add iommu_copy_struct_from_user helper")
> Cc: stable@...r.kernel.org
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>