linux-kernel - Re: [PATCH] smb: server: smb2pdu: check return value of xa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd83Pj37B9vuytFjXrL67_ohMBSjoQKM+6PdvzrqVxjxag@mail.gmail.com>
Date: Tue, 15 Apr 2025 09:43:53 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Salah Triki <salah.triki@...il.com>
Cc: Steve French <smfrench@...il.com>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smb: server: smb2pdu: check return value of xa_store()

On Tue, Apr 15, 2025 at 4:25 AM Salah Triki <salah.triki@...il.com> wrote:
>
> xa_store() may fail so check its return value and return error code if
> error occurred.
>
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/smb/server/smb2pdu.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
> index d24d95d15d87..e32f8910e892 100644
> --- a/fs/smb/server/smb2pdu.c
> +++ b/fs/smb/server/smb2pdu.c
> @@ -1445,7 +1445,7 @@ static int ntlm_authenticate(struct ksmbd_work *work,
>  {
>         struct ksmbd_conn *conn = work->conn;
>         struct ksmbd_session *sess = work->sess;
> -       struct channel *chann = NULL;
> +       struct channel *chann = NULL, *old;
>         struct ksmbd_user *user;
>         u64 prev_id;
>         int sz, rc;
> @@ -1557,7 +1557,10 @@ static int ntlm_authenticate(struct ksmbd_work *work,
>                                 return -ENOMEM;
>
>                         chann->conn = conn;
> -                       xa_store(&sess->ksmbd_chann_list, (long)conn, chann, KSMBD_DEFAULT_GFP);
> +                       old = xa_store(&sess->ksmbd_chann_list, (long)conn, chann,
> +                                       KSMBD_DEFAULT_GFP);
> +                       if (xa_is_err(old))
We need to free chann before returning the error.
Thanks.
> +                               return xa_err(old);
>                 }
>         }
>
> --
> 2.43.0
>