linux-kernel - Re: [PATCH v1] sched_ext: Improve cross-compilation support in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+P2CkaDAjwGE1L0CA60K9bnSMaZAw6zR_psFKfS2DxGBtm6Kg@mail.gmail.com>
Date: Tue, 15 Apr 2025 15:32:41 +0800
From: Eric yang <jluyangsonghua@...il.com>
To: Tejun Heo <tj@...nel.org>
Cc: void@...ifault.com, arighi@...dia.com, changwoo@...lia.com, 
	linux-kernel@...r.kernel.org, sched-ext@...a.com, 
	yangsonghua <yangsonghua@...iang.com>
Subject: Re: [PATCH v1] sched_ext: Improve cross-compilation support in Makefile

Hi Tejun,

I am pleased to receive your feedback. Based on your suggestions, I
have submitted a v2 patch.
Link：https://lore.kernel.org/lkml/20250415054642.3878839-1-yangsonghua@lixiang.com/

Additionally, I have tested both v1 patch and v2 patch, they work
correctly in native builds or
cross-compilation scenarios.

Thank you for your guidance.
- Eric


Tejun Heo <tj@...nel.org> 于2025年4月15日周二 01:01写道：
>
> On Mon, Apr 14, 2025 at 04:14:36PM +0800, yangsonghua wrote:
> > Modify the tools/sched_ext/Makefile to better handle cross-compilation
> > environments by:
> >
> > 1. Fix host tools build directory structure by separating obj/ from output
> >    (HOST_BUILD_DIR now points to $(OBJ_DIR)/host/obj)
> > 2. Properly propagate CROSS_COMPILE to libbpf sub-make invocation
> > 3. Add missing $(HOST_BPFOBJ) build rule with proper host toolchain flags
> >    (ARCH=, CROSS_COMPILE=, explicit HOSTCC/HOSTLD)
> > 4. Consistently quote $(HOSTCC) in bpftool build rule
> > 5. Change LDFLAGS assignment to += to allow external extensions
> >
> > The changes ensure proper cross-compilation behavior while maintaining
> > backward compatibility with native builds. Host tools are now correctly
> > built with the host toolchain while target binaries use the cross-toolchain.
> >
> > Signed-off-by: yangsonghua <yangsonghua@...iang.com>
>
> Doesn't break native builds at least. I take your words that this improves
> cross-builds. Applied to sched_ext/for-6.16.
>
> Thanks.
>
> --
> tejun