linux-kernel - Re: [PATCH v7 6/6] riscv: defconfig: spacemit: enable clock controller driver for SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2gpmtaxfbt3ltgrz26uyu2gzffrp6gstov22qvguiz4md33lw@y26mzzc4wnnd>
Date: Tue, 15 Apr 2025 08:53:53 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Alex Elder <elder@...cstar.com>, Haylen Chu <heylenay@....org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Haylen Chu <heylenay@...look.com>, Yixun Lan <dlan@...too.org>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>
Cc: linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, spacemit@...ts.linux.dev, 
	Inochi Amaoto <inochiama@...look.com>, Chen Wang <unicornxdotw@...mail.com>, 
	Jisheng Zhang <jszhang@...nel.org>, Meng Zhang <zhangmeng.kevin@...ux.spacemit.com>
Subject: Re: [PATCH v7 6/6] riscv: defconfig: spacemit: enable clock
 controller driver for SpacemiT K1

On Mon, Apr 14, 2025 at 01:12:32PM -0500, Alex Elder wrote:
> On 4/12/25 2:44 AM, Haylen Chu wrote:
> > Clock controller unit, or CCU, generates various clocks frequency for
> > peripherals integrated in SpacemiT K1 SoC and is essential for normal
> > operation. Let's enable it as built-in driver in defconfig.
> > 
> > Signed-off-by: Haylen Chu <heylenay@....org>
> 

> I know Inochi wanted this to be "m", but you can see that
> SOPHGO sets it to "y".  Meanwhile SIFIVE uses a default
> value for its CLK_SIFIVE and CLK_SIFIVE_PRCI config options.
> 
> I'm not going to solve this, so I'll just say this looks good.
> 

The clock and pinctrl are exceptions for me, It is OK for me to set
"y" for these two device in defconfig. The thing I only asked for is 
a tristate entry in the kconfig, so we can go with a module if 
necessary.

Regards,
Inochi