linux-kernel - Re: [PATCH v5 2/2] iio: adc: add support for Nuvoton NCT7201

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_4YLq_uR_6uroNd@smile.fi.intel.com>
Date: Tue, 15 Apr 2025 11:26:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yu-Hsian Yang <j2anfernee@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	javier.carrasco.cruz@...il.com, gstols@...libre.com,
	tgamblin@...libre.com, alisadariana@...il.com,
	antoniu.miclaus@...log.com, eblanc@...libre.com,
	jstephan@...libre.com, matteomartelli3@...il.com,
	angelogioacchino.delregno@...labora.com, herve.codina@...tlin.com,
	marcelo.schmitt@...log.com, chanh@...amperecomputing.com,
	KWLIU@...oton.com, yhyang2@...oton.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] iio: adc: add support for Nuvoton NCT7201

On Mon, Apr 14, 2025 at 09:40:35PM +0800, Yu-Hsian Yang wrote:
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> 於 2025年4月10日 週四 上午12:19寫道：
> > On Wed, Apr 09, 2025 at 09:23:51AM +0800, Eason Yang wrote:

...

> > Here and elsewhere why ' < 0' is used? Do you expect positive return values
> > from those?
> 
> In regmap_read function, A value of zero will be returned on success,
> a negative errno will be returned in error cases.
> We don't have a positive return case.

So, can we remove ' < 0' parts where they are not required, please?

...

> > > +     chip->client = client;
> >
> > How exactly is _client_ used elsewhere? Shouldn't it be just a struct device
> > pointer?
> 
> Yes, it is just a struct device pointer.
> In nct7201_init_chip(chip), we would use the chip->client->dev as
> dev_err_probe() parameter

Just save there struct device *dev and use chip->dev instead.

-- 
With Best Regards,
Andy Shevchenko