linux-kernel - Re: [PATCH] btrfs: remove BTRFS_REF_LAST from btrfs_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e158208-4914-4bfb-984a-0d35e8b93225@gmx.com>
Date: Tue, 15 Apr 2025 18:46:48 +0930
From: Qu Wenruo <quwenruo.btrfs@....com>
To: 李扬韬 <frank.li@...o.com>, "clm@...com" <clm@...com>,
 "josef@...icpanda.com" <josef@...icpanda.com>,
 "dsterba@...e.com" <dsterba@...e.com>
Cc: "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] btrfs: remove BTRFS_REF_LAST from btrfs_ref_type



在 2025/4/15 18:26, 李扬韬 写道:
>> History please.
>
> Did you mean change commit msg to below?
>
> 	Commit b28b1f0ce44c ("btrfs: delayed-ref: Introduce better documented delayed ref structures") introduce BTRFS_REF_LAST but never use it,
> 	So let's remove it.

It's the common practice to leave a last entry for sanity checks.

But since it's not utilized for anything, I'm fine to remove it.

>
>> The _LAST or _NR suffix can be utilized to do sanity checks, and this is not part of the on-disk format.
>
> IIRC, delayed ref belongs to the extent tree memory kv cache.
>
>> And if this exposed by some automatic tools, please also mention it.
>
> I'm just looking at this code.
>
> Thx,
> Yangtao