linux-kernel - Re: [PATCH v5 5/5] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250415095605.8607-1-trannamatk@gmail.com>
Date: Tue, 15 Apr 2025 16:56:05 +0700
From: Nam Tran <trannamatk@...il.com>
To: krzk+dt@...nel.org
Cc: pavel@...nel.org,
	lee@...nel.org,
	robh@...nel.org,
	conor+dt@...nel.org,
	corbet@....net,
	devicetree@...r.kernel.org,
	linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B

On Mon, 14 Apr 2025, Krzysztof Kozlowski wrote:

> On 14/04/2025 16:57, Nam Tran wrote:
> > Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> > This enables the LED connected to the LP5812 to be controlled via I2C.
> > 
> > Signed-off-by: Nam Tran <trannamatk@...il.com>
> > ---
> >  .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 60 +++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > index 353bb50ce542..0dec6ce44c6c 100644
> > --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> > @@ -152,6 +152,66 @@ &hdmi1 {
> >  	status = "okay";
> >  };
> >  
> > +&i2c1 {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		led-controller@1b {
> > +				compatible = "ti,lp5812";
> > +				reg = <0x1b>;
> 
> Messed indentation... You already got such comment about your DTS in the
> binding. :/

Thank you for pointing it out. I fixed the indentation in the binding file but overlooked it here.
I'll make sure it's corrected in the next version.

Best regards,
Nam Tran