linux-kernel - Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b644c042602cac5096b32c0d61e5a2f7acdbcfa0.camel@intel.com>
Date: Tue, 15 Apr 2025 01:51:34 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "Li, Xiaoyao" <xiaoyao.li@...el.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "binbin.wu@...ux.intel.com"
	<binbin.wu@...ux.intel.com>
CC: "mikko.ylinen@...ux.intel.com" <mikko.ylinen@...ux.intel.com>, "Gao, Chao"
	<chao.gao@...el.com>, "Huang, Kai" <kai.huang@...el.com>, "Chatre, Reinette"
	<reinette.chatre@...el.com>, "Lindgren, Tony" <tony.lindgren@...el.com>,
	"Zhao, Yan Y" <yan.y.zhao@...el.com>, "Hunter, Adrian"
	<adrian.hunter@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Yamahata, Isaku" <isaku.yamahata@...el.com>
Subject: Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

On Tue, 2025-04-15 at 09:49 +0800, Xiaoyao Li wrote:
> > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> > index c6988e2c68d5..eca86b7f0cbc 100644
> > --- a/include/uapi/linux/kvm.h
> > +++ b/include/uapi/linux/kvm.h
> > @@ -178,6 +178,7 @@ struct kvm_xen_exit {
> >    #define KVM_EXIT_NOTIFY           37
> >    #define KVM_EXIT_LOONGARCH_IOCSR  38
> >    #define KVM_EXIT_MEMORY_FAULT     39
> > +#define KVM_EXIT_TDX_GET_QUOTE    41
> 
> Number 40 is skipped and I was told internally the reason is mentioned 
> in cover letter
> 
>      Note that AMD has taken 40 for KVM_EXIT_SNP_REQ_CERTS in the
>      patch [4] under review, to avoid conflict, use number 41 for
>      KVM_EXIT_TDX_GET_QUOTE and number 42 for
>      KVM_EXIT_TDX_SETUP_EVENT_NOTIFY.
> 
> I think we shouldn't give up number 40 unless this series depends on AMD 
> one or it's agreement that AMD one will be queued/merged earlier.

Yes, if this patch needed to sit in kvm-coco-queue with AMD patches for awhile
it might make sense. But it sounds like the plan is to include it in base
support.