linux-kernel - Re: [PATCH v8] fuse: add more control over cache invalidation behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mschn1gt.fsf@igalia.com>
Date: Tue, 15 Apr 2025 11:49:54 +0100
From: Luis Henriques <luis@...lia.com>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: Laura Promberger <laura.promberger@...n.ch>,  Bernd Schubert
 <bschubert@....com>,  Dave Chinner <david@...morbit.com>,  Matt Harvey
 <mharvey@...ptrading.com>,  "linux-fsdevel@...r.kernel.org"
 <linux-fsdevel@...r.kernel.org>,  "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8] fuse: add more control over cache invalidation
 behaviour

On Tue, Apr 15 2025, Miklos Szeredi wrote:

> On Tue, 15 Apr 2025 at 12:34, Luis Henriques <luis@...lia.com> wrote:
>>
>> Hi Laura,
>>
>> On Fri, Apr 11 2025, Laura Promberger wrote:
>>
>> > Hello Miklos, Luis,
>> >
>> > I tested Luis NOTIFY_INC_EPOCH patch (kernel, libfuse, cvmfs) on RHEL9 and can
>> > confirm that in combination with your fix to the symlink truncate it solves all
>> > the problem we had with cvmfs when applying a new revision and at the same time
>> > hammering a symlink with readlink() that would change its target. (
>> > https://github.com/cvmfs/cvmfs/issues/3626 )
>> >
>> > With those two patches we no longer end up with corrupted symlinks or get stuck on an old revision.
>> > (old revision was possible because the kernel started caching the old one again during the update due to the high access rate and the asynchronous evict of inodes)
>> >
>> > As such we would be very happy if this patch could be accepted.
>>
>> Even though this patch and the one that fixed the symlinks corruption [1]
>> aren't really related, it's always good to have extra testing.  Thanks a
>> lot for your help, Laura.
>>
>> In the meantime, I hope to send a refreshed v9 of this patch soon (maybe
>> today) as it doesn't apply cleanly to current master anymore.  And I also
>> plan to send v2 of the (RFC) patch that adds the workqueue to clean-up
>> expired cache entries.
>
> Don't bother, I just applied the patch with the conflicts fixed up.

Oh, awesome!  Thanks a lot, Miklos.  I'll focus on the other patch and try
to send v2 later today.

Cheers,
-- 
Luís