linux-kernel - Re: [PATCH next] usb: typec: class: Unlocked on error in typec_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_46or5827D8xKm3@kuha.fi.intel.com>
Date: Tue, 15 Apr 2025 13:53:22 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Andrei Kuchynski <akuchynski@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Benson Leung <bleung@...omium.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] usb: typec: class: Unlocked on error in
 typec_register_partner()

On Tue, Apr 15, 2025 at 01:45:08PM +0300, Dan Carpenter wrote:
> We recently added some locking to this function but this error path
> was accidentally missed.  Unlock before returning.
> 
> Fixes: ec27386de23a ("usb: typec: class: Fix NULL pointer access")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/class.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 3df3e3736916..67a533e35150 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
>  	ret = device_register(&partner->dev);
>  	if (ret) {
>  		dev_err(&port->dev, "failed to register partner (%d)\n", ret);
> +		mutex_unlock(&port->partner_link_lock);
>  		put_device(&partner->dev);
>  		return ERR_PTR(ret);
>  	}
> -- 
> 2.47.2
> 

-- 
heikki