linux-kernel - [PATCH] ASoC: SOF: topology: Replace devm_kasprintf() call by devm_kstrdup() in sof_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3e473ff5-1554-4065-a305-6b3661e0b941@web.de>
Date: Wed, 16 Apr 2025 15:08:28 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-sound@...r.kernel.org, sound-open-firmware@...a-project.org,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>, Jaroslav Kysela <perex@...ex.cz>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Chenyuan Yang
 <chenyuan0y@...il.com>, Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH] ASoC: SOF: topology: Replace devm_kasprintf() call by
 devm_kstrdup() in sof_copy_tuples()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 16 Apr 2025 14:44:58 +0200

Use a devm_kstrdup() call instead of a devm_kasprintf() call
in this function implementation because only a single string
should be copied.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 sound/soc/sof/topology.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index e19ba94f2c80..49462140facc 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -572,8 +572,9 @@ static int sof_copy_tuples(struct snd_sof_dev *sdev, struct snd_soc_tplg_vendor_
 
 					tuples[*num_copied_tuples].token = tokens[j].token;
 					tuples[*num_copied_tuples].value.s =
-						devm_kasprintf(sdev->dev, GFP_KERNEL,
-							       "%s", elem->string);
+						devm_kstrdup(sdev->dev,
+							     elem->string,
+							     GFP_KERNEL);
 					if (!tuples[*num_copied_tuples].value.s)
 						return -ENOMEM;
 				} else {
-- 
2.49.0