linux-kernel - [PATCH] HID: logitech-hidpp: Replace devm_kasprintf() call by devm_kstrdup() in hidpp_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <99e0a0e0-1b21-4e94-a9ff-2dc5715d676d@web.de>
Date: Wed, 16 Apr 2025 15:32:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-input@...r.kernel.org, Bastien Nocera <hadess@...ess.net>,
 Benjamin Tissoires <bentiss@...nel.org>, Filipe Laíns
 <lains@...eup.net>, Jiri Kosina <jikos@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Chenyuan Yang
 <chenyuan0y@...il.com>, Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH] HID: logitech-hidpp: Replace devm_kasprintf() call by
 devm_kstrdup() in hidpp_connect_event()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 16 Apr 2025 15:25:05 +0200

Use a devm_kstrdup() call instead of a devm_kasprintf() call
in this function implementation because only a single string
should be copied.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/hid/hid-logitech-hidpp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 10a3bc5f931b..c1a9ecde57c6 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4216,8 +4216,7 @@ static void hidpp_connect_event(struct work_struct *work)
 	if (hidpp->name == hdev->name && hidpp->protocol_major >= 2) {
 		name = hidpp_get_device_name(hidpp);
 		if (name) {
-			devm_name = devm_kasprintf(&hdev->dev, GFP_KERNEL,
-						   "%s", name);
+			devm_name = devm_kstrdup(&hdev->dev, name, GFP_KERNEL);
 			kfree(name);
 			if (!devm_name)
 				return;
-- 
2.49.0