linux-kernel - Re: [FIRST-PATCH] staging : greybus : gb-beagleplay.c : fixing the checks as first-patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_-11fvQJtiwAxaA@hovoldconsulting.com>
Date: Wed, 16 Apr 2025 15:51:17 +0200
From: Johan Hovold <johan@...nel.org>
To: rujra <braker.noob.kernel@...il.com>
Cc: ayushdevel1325@...il.com, elder@...nel.org, gregkh@...uxfoundation.org,
	greybus-dev@...ts.linaro.org, outreachy@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [FIRST-PATCH] staging : greybus : gb-beagleplay.c : fixing the
 checks as first-patch

On Wed, Apr 16, 2025 at 05:47:41PM +0530, rujra wrote:
> added comments on spinlocks for producer-consumer model, rearranged the
> lines on function calls where it should not end with "(" this bracket,
> also removed white-spaces and aligned the arguments of function calls.
> 
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@...il.com>

You're doing too many things in one patch, the patch is white space
damaged, and the patch prefix is wrong since this driver does not live
in staging.

If you want to practise creating patches, please make sure to work in
drivers/staging where changes like these may be accepted. 

Johan