linux-kernel - [PATCH v3] arm/memremap: fix arch_memremap_can_ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416135233.1421962-1-ross.stutterheim@garmin.com>
Date: Wed, 16 Apr 2025 08:52:33 -0500
From: Ross Stutterheim <ross.stutterheim@...min.com>
To: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: Russell King <linux@...linux.org.uk>, Mike Rapoport <rppt@...ux.ibm.com>,
        <ross.stutterheim@...min.com>, <ross.sweng@...il.com>,
        Mike Rapoport
	<rppt@...nel.org>, <stable@...r.kernel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: [PATCH v3] arm/memremap: fix arch_memremap_can_ram_remap()

commit 260364d112bc ("arm[64]/memremap: don't abuse pfn_valid() to ensure
presence of linear map") added the definition of
arch_memremap_can_ram_remap() for arm[64] specific filtering of what pages
can be used from the linear mapping. memblock_is_map_memory() was called
with the pfn of the address given to arch_memremap_can_ram_remap();
however, memblock_is_map_memory() expects to be given an address for arm,
not a pfn.

This results in calls to memremap() returning a newly mapped area when
it should return an address in the existing linear mapping.

Fix this by removing the address to pfn translation and pass the
address directly.

Fixes: 260364d112bc ("arm[64]/memremap: don't abuse pfn_valid() to ensure presence of linear map")
Signed-off-by: Ross Stutterheim <ross.stutterheim@...min.com>
Cc: Mike Rapoport <rppt@...nel.org>
Cc: Russell King <linux@...linux.org.uk>
Cc: stable@...r.kernel.org
Reviewed-by: Catalin Marinas <catalin.marinas@....com>
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
---
 arch/arm/mm/ioremap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mm/ioremap.c b/arch/arm/mm/ioremap.c
index 748698e91a4b..27e64f782cb3 100644
--- a/arch/arm/mm/ioremap.c
+++ b/arch/arm/mm/ioremap.c
@@ -515,7 +515,5 @@ void __init early_ioremap_init(void)
 bool arch_memremap_can_ram_remap(resource_size_t offset, size_t size,
 				 unsigned long flags)
 {
-	unsigned long pfn = PHYS_PFN(offset);
-
-	return memblock_is_map_memory(pfn);
+	return memblock_is_map_memory(offset);
 }
-- 
2.49.0