lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <44df2f04-655e-47cc-8785-0855377c4bf7@web.de>
Date: Wed, 16 Apr 2025 16:30:20 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: kernel-janitors@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Chenyuan Yang <chenyuan0y@...il.com>
Subject: [PATCH] misc: sram: Replace devm_kasprintf() call by devm_kstrdup()
 in sram_reserve_regions()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 16 Apr 2025 16:10:06 +0200

Use a devm_kstrdup() call instead of a devm_kasprintf() call
in this function implementation because only a single string
should be copied.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/misc/sram.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
index e5069882457e..5a2412ca43cd 100644
--- a/drivers/misc/sram.c
+++ b/drivers/misc/sram.c
@@ -235,8 +235,9 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
 				goto err_chunks;
 			}
 			if (!label)
-				block->label = devm_kasprintf(sram->dev, GFP_KERNEL,
-							      "%s", of_node_full_name(child));
+				block->label = devm_kstrdup(sram->dev,
+							    of_node_full_name(child),
+							    GFP_KERNEL);
 			else
 				block->label = devm_kstrdup(sram->dev,
 							    label, GFP_KERNEL);
-- 
2.49.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ