linux-kernel - Re: [PATCH v5 6/8] arm64: dts: freescale: Add the GOcontroll Moduline Display baseboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z//BEiuaxmWVrYiZ@lizhi-Precision-Tower-5810>
Date: Wed, 16 Apr 2025 10:39:14 -0400
From: Frank Li <Frank.li@....com>
To: Maud Spierings | GOcontroll <maudspierings@...ontroll.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 6/8] arm64: dts: freescale: Add the GOcontroll
 Moduline Display baseboard

On Wed, Apr 16, 2025 at 09:06:39AM +0000, Maud Spierings | GOcontroll wrote:
> On 4/15/25 20:58, Frank Li wrote:
> > On Tue, Apr 15, 2025 at 08:54:29AM +0200, Maud Spierings via B4 Relay wrote:
> >> From: Maud Spierings <maudspierings@...ontroll.com>
> >>
> >> The Moduline Display platform is a part of the wider GOcontroll Moduline
> >> ecosystem. These are embedded controllers that focus on modularity with
> >> their swappable IO modules.
> >>
> >> The base Moduline Display board includes a board-to-board connector with
> >> various busses to enable adding new display types required by the
> >> application. It includes 2 Moduline IO module slots, a simple mono
> >> codec/amplifier, a four channel adc, 2 CAN busses, an RTC and optional
> >> wifi/bluetooth.
> >>
> >> busses to the display adapter include:
> >> - 4 lane LVDS
> >> - 4 lane MIPI-DSI
> >> - 4 lane MIPI-CSI
> >> - HDMI 2.0a
> >> - USB 2.0
> >> - I2S
> >> - I2C
> >> - SPI
> >>
> >> Also a couple of GPIO and PWM pins for controlling various ICs on the
> >> display adapter board.
> >>
> >> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
> >> ---
> [...]
> >> +
> >> +&ecspi1 {
> >> +	cs-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>,
> >> +			   <&gpio1 11 GPIO_ACTIVE_LOW>,
> >> +			   <&gpio1 10 GPIO_ACTIVE_LOW>;
> >
> > indention mess!
> I'm not really sure how to resolve this correctly, currently the next
> lines have three tabs and three spaces, which lines up which tab = 4
> spaces but that is not the case for everyone.
>
> I just saw two other ways this was done:
> 4 tabs (doesn't line up at all)
> 2 tabs and 3 spaces (doesn't line up for tab = 4 spaces but does for tab
> = 8 spaces

Linux code tab already 8. It should 2 tab + 3 space. but it is 3 tab + 3
space in patch.

Frank
>
> Another way I thought is 1 tab and 11 spaces which lines up for all
> cases, but excessive amount of spaces.
>
> > Frank
> --
> Met vriendelijke groeten/with kind regards,
> Maud Spierings