linux-kernel - Re: [PATCH net-next v3] net: lan743x: Allocate rings outside ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416151410.GR395307@horms.kernel.org>
Date: Wed, 16 Apr 2025 16:14:10 +0100
From: Simon Horman <horms@...nel.org>
To: Thangaraj Samynathan <thangaraj.s@...rochip.com>
Cc: netdev@...r.kernel.org, bryan.whitehead@...rochip.com,
	UNGLinuxDriver@...rochip.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: lan743x: Allocate rings outside ZONE_DMA

On Tue, Apr 15, 2025 at 10:15:09AM +0530, Thangaraj Samynathan wrote:
> The driver allocates ring elements using GFP_DMA flags. There is
> no dependency from LAN743x hardware on memory allocation should be
> in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC. This
> is consistent with other callers of lan743x_rx_init_ring_element().
> 
> Reported-by: Zhang, Liyin(CN) <Liyin.Zhang.CN@...driver.com>
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@...rochip.com>
> ---
> v0
> -Initial Commit
> 
> v1
> -Modified GFP flags from GFP_KERNEL to GFP_ATOMIC
> 
> v2
> -resubmit to net-next
> 
> v3
> -Shortened prefix and updated commit message

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>