linux-kernel - Re: [PATCH REGRESSION-FIX] x86/paravirt: Move halt paravirt calls under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGtprH-iO-Bk3bsqMCkdRp4xOQWzHsOVY7DDNyxh3u6AmhMBFg@mail.gmail.com>
Date: Tue, 15 Apr 2025 19:25:22 -0700
From: Vishal Annapurve <vannapurve@...gle.com>
To: bmastbergen@....com
Cc: stable@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, 
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H. Peter Anvin" <hpa@...or.com>, Juergen Gross <jgross@...e.com>, Ajay Kaher <ajay.kaher@...adcom.com>, 
	Alexey Makhalov <alexey.amakhalov@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, 
	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org, 
	virtualization@...ts.linux.dev, regressions@...ts.linux.dev, 
	Ingo Molnar <mingo@...nel.org>, Ryan Afranji <afranji@...gle.com>, Andy Lutomirski <luto@...nel.org>, 
	Brian Gerst <brgerst@...il.com>, Linus Torvalds <torvalds@...ux-foundation.org>, stable@...nel.org, 
	Josh Poimboeuf <jpoimboe@...nel.org>
Subject: Re: [PATCH REGRESSION-FIX] x86/paravirt: Move halt paravirt calls
 under CONFIG_PARAVIRT

> ...
> 6.12.23 fails to build with the following error if CONFIG_XEN_PV is
> not set:
>
> arch/x86/coco/tdx/tdx.c: In function ‘tdx_early_init’:
> arch/x86/coco/tdx/tdx.c:1080:19: error: ‘struct pv_irq_ops’ has no member
> named ‘safe_halt’
>  1080 |         pv_ops.irq.safe_halt = tdx_safe_halt;
>       |                   ^
> arch/x86/coco/tdx/tdx.c:1081:19: error: ‘struct pv_irq_ops’ has no member
> named ‘halt’
>  1081 |         pv_ops.irq.halt = tdx_halt;
>       |                   ^
>
> This is because XEN_PV selects PARAVIRT_XXL, and 'safe_halt' and
> 'halt' are only defined for pv_irq_ops if PARAVIRT_XXL is defined.
>
> The build breakage was introduced in 6.12.23 by stable commit
> 805e3ce5e0e3 which is a backport of 9f98a4f4e721 ("x86/tdx: Fix
> arch_safe_halt() execution for TDX VMs").
>
> Consider picking up upstream commit 22cc5ca5de52 ("x86/paravirt:
> Move halt paravirt calls under CONFIG_PARAVIRT") for stable 6.12.y
> which fixes the build regression by moving 'safe_halt' and 'halt'
> out from under the PARAVIRT_XXL config.
>
> This patch is 22cc5ca5de52 backported to 6.12.23.  There were a
> couple of merge conflicts due to the missing upstream commits below:
>

Thanks Brett for looking into this. I have posted a similar patch [1]
and I see that the issue you reported is also being discussed already
[2].

[1] https://lore.kernel.org/stable/20250408132341.4175633-1-vannapurve@google.com/
[2] https://lore.kernel.org/stable/20250410180423.GA3430900@ax162/