linux-kernel - Re: [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z__x2hboc3RQC6Je@blossom>
Date: Wed, 16 Apr 2025 14:07:22 -0400
From: Alyssa Rosenzweig <alyssa@...enzweig.io>
To: j@...nau.net
Cc: Sven Peter <sven@...npeter.dev>, Neal Gompa <neal@...pa.dev>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nick Chan <towinchenmi@...il.com>,
	Sasha Finkelstein <fnkl.kernel@...il.com>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as
 always-on

Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>

Thanks for debugging this

Le Wed , Apr 16, 2025 at 08:06:18PM +0200, Janne Grunau via B4 Relay a écrit :
> From: Janne Grunau <j@...nau.net>
> 
> The driver depends on boot loader initialized state which resets when the
> ps_dispdfr_be power-domain is powered off. This happens on suspend or
> when the driver is missing during boot.
> Mark the domain as always on until the driver can handle this.
> 
> Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
> Signed-off-by: Janne Grunau <j@...nau.net>
> ---
>  arch/arm64/boot/dts/apple/t8103-j293.dts | 10 ++++++++++
>  arch/arm64/boot/dts/apple/t8112-j493.dts | 10 ++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 2dfe7b895b2bc0a913e73141e558fa5124a13b2e..e2d9439397f71a93c28b75a7eea589f4bcb3e374 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -77,6 +77,16 @@ touchbar0: touchbar@0 {
>  	};
>  };
>  
> +/*
> + * The driver depends on boot loader initialized state which resets when this
> + * power-domain is powered off. This happens on suspend or when the driver is
> + * missing during boot. Mark the domain as always on until the driver can
> + * handle this.
> + */
> +&ps_dispdfr_be {
> +	apple,always-on;
> +};
> +
>  &display_dfr {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index 3d73f9ee2f46a35a3b23da5b233ef316c7372ef7..be86d34c6696cb47d31696541266e504cee8ce10 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
> @@ -40,6 +40,16 @@ led-0 {
>  	};
>  };
>  
> +/*
> + * The driver depends on boot loader initialized state which resets when this
> + * power-domain is powered off. This happens on suspend or when the driver is
> + * missing during boot. Mark the domain as always on until the driver can
> + * handle this.
> + */
> +&ps_dispdfr_be {
> +	apple,always-on;
> +};
> +
>  &display_dfr {
>  	status = "okay";
>  };
> 
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250416-arm64_dts_apple_touchbar-658cd974de97
> 
> Best regards,
> -- 
> Janne Grunau <j@...nau.net>
> 
>