linux-kernel - Re: [PATCH] clk: qcom: Fix missing error check for dev_pm_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174482704420.446874.1566095107641115785.b4-ty@kernel.org>
Date: Wed, 16 Apr 2025 13:10:46 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: mturquette@...libre.com,
	sboyd@...nel.org,
	Wentao Liang <vulab@...as.ac.cn>
Cc: linux-arm-msm@...r.kernel.org,
	linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: Fix missing error check for dev_pm_domain_attach()


On Tue, 11 Feb 2025 17:20:17 +0800, Wentao Liang wrote:
> In the current implementation, the return value of dev_pm_domain_attach()
> is not checked. This can lead to silent failures if the function fails,
> as the code would continue execution and return 0, ignoring the error.
> 
> This patch adds a check for the return value of dev_pm_domain_attach().
> If the function fails, an error message is logged using dev_err_probe(),
> and the error is propagated to the existing error handling path `err`,
> which ensures proper cleanup by calling clk_notifier_unregister().
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: Fix missing error check for dev_pm_domain_attach()
      commit: 36eb51ac8bd545b6344c05a9860e4e65ba8d7a62

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>