linux-kernel - Re: [PATCH v7 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a03efee0-3470-4d7f-9a63-3ec9f1ae4f3a@oracle.com>
Date: Thu, 17 Apr 2025 00:43:33 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Werner Sembach <wse@...edocomputers.com>, hdegoede@...hat.com,
        ilpo.jarvinen@...ux.intel.com, bentiss@...nel.org
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v7 1/1] platform/x86/tuxedo: Add virtual LampArray for
 TUXEDO NB04 devices



On 16-04-2025 22:41, Werner Sembach wrote:
> +	for (unsigned int i = 0; i < rep->lamp_count; ++i) {
> +		if (rep->lamp_id[i] > driver_data->lamp_count) {
> +			hid_dbg(hdev, "Out of bounds lamp_id in lamp_multi_update_report. Skippng whole report!\n");
> +			return sizeof(*rep);
> +		}

typo -Skippng

> +
> +		for (unsigned int j = i + 1; j < rep->lamp_count; ++j) {
> +			if (rep->lamp_id[i] == rep->lamp_id[j]) {
> +				hid_dbg(hdev, "Duplicate lamp_id in lamp_multi_update_report. Skippng whole report!\n");
> +				return sizeof(*rep);
> +			}
> +		}
> +	}


Thanks,
Alok