linux-kernel - Re: 回复: [PATCH] btrfs: remove BTRFS_REF_LAST from btrfs_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250416191806.GE13877@suse.cz>
Date: Wed, 16 Apr 2025 21:18:06 +0200
From: David Sterba <dsterba@...e.cz>
To: 李扬韬 <frank.li@...o.com>
Cc: Qu Wenruo <quwenruo.btrfs@....com>, "clm@...com" <clm@...com>,
	"josef@...icpanda.com" <josef@...icpanda.com>,
	"dsterba@...e.com" <dsterba@...e.com>,
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH] btrfs: remove
 BTRFS_REF_LAST from btrfs_ref_type

On Wed, Apr 16, 2025 at 01:25:34PM +0000, 李扬韬 wrote:
> > I think in this case it's ok to remove it, although I agree that we have the _LAST or _NR elsewhere. In btrfs_ref_type() tere's an assertion
> 
> >  ASSERT(ref->type == BTRFS_REF_DATA || ref->type == BTRFS_REF_METADATA);
> 
> > which is validating the values. There's no enumeration or switch that could utilize the upper bound.
> 
> Do I need to modify the submission information and resend this patch?

Yes please, the reasoning was missing from the original patch, we've
come to a conclusion in the discussion so this should be summarized in
v2.