linux-kernel - Re: [PATCH 2/4] ubsan: Remove regs from report_ubsan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504161246.AB73A176C@keescook>
Date: Wed, 16 Apr 2025 12:47:08 -0700
From: Kees Cook <kees@...nel.org>
To: Mostafa Saleh <smostafa@...gle.com>
Cc: kvmarm@...ts.linux.dev, kasan-dev@...glegroups.com,
	linux-hardening@...r.kernel.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	will@...nel.org, maz@...nel.org, oliver.upton@...ux.dev,
	broonie@...nel.org, catalin.marinas@....com, tglx@...utronix.de,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
	x86@...nel.org, hpa@...or.com, elver@...gle.com,
	andreyknvl@...il.com, ryabinin.a.a@...il.com,
	akpm@...ux-foundation.org, yuzenghui@...wei.com,
	suzuki.poulose@....com, joey.gouly@....com, masahiroy@...nel.org,
	nathan@...nel.org, nicolas.schier@...ux.dev
Subject: Re: [PATCH 2/4] ubsan: Remove regs from report_ubsan_failure()

On Wed, Apr 16, 2025 at 06:04:32PM +0000, Mostafa Saleh wrote:
> report_ubsan_failure() doesn't use argument regs, and soon it will
> be called from the hypervisor context were regs are not available.
> So, remove the unused argument.
> 
> Signed-off-by: Mostafa Saleh <smostafa@...gle.com>

Funny. I wonder why I put that argument in there? If we ever need it
again, we can just make it conditional (and let the hypervisor pass
NULL).

Acked-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook