linux-kernel - Re: [PATCH v17 1/3] lsm, selinux: Add setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a4b0f45-1eb5-4eb7-b120-6b50ea0d4835@schaufler-ca.com>
Date: Wed, 16 Apr 2025 15:58:54 -0700
From: Casey Schaufler <casey@...aufler-ca.com>
To: Li Li <dualli@...omium.org>
Cc: dualli@...gle.com, corbet@....net, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 donald.hunter@...il.com, gregkh@...uxfoundation.org, arve@...roid.com,
 tkjos@...roid.com, maco@...roid.com, joel@...lfernandes.org,
 brauner@...nel.org, cmllamas@...gle.com, surenb@...gle.com,
 omosnace@...hat.com, shuah@...nel.org, arnd@...db.de, masahiroy@...nel.org,
 bagasdotme@...il.com, horms@...nel.org, tweek@...gle.com,
 paul@...l-moore.com, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, netdev@...r.kernel.org, selinux@...r.kernel.org,
 hridya@...gle.com, smoreland@...gle.com, ynaffit@...gle.com,
 kernel-team@...roid.com, Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH v17 1/3] lsm, selinux: Add setup_report permission to
 binder

On 4/16/2025 9:00 AM, Li Li wrote:
> Thank you Casey! I'll resend this specific patch to linux-security-module list.
>
> Should I include the other 2 binder patches as well as they are using
> this new permission?

I would appreciate it. Context can be pretty important. Sometimes 
"why" an LSM hook is being added impacts who reviews it.

>
> On Tue, Apr 15, 2025 at 9:13 AM Casey Schaufler <casey@...aufler-ca.com> wrote:
>> On 4/15/2025 12:10 AM, Li Li wrote:
>>> From: Thiébaud Weksteen <tweek@...gle.com>
>>>
>>> Introduce a new permission "setup_report" to the "binder" class.
>>> This persmission controls the ability to set up the binder generic
>>> netlink driver to report certain binder transactions.
>>>
>>> Signed-off-by: Thiébaud Weksteen <tweek@...gle.com>
>>> Signed-off-by: Li Li <dualli@...gle.com>
>>> ---
>>>  include/linux/lsm_hook_defs.h       |  1 +
>>>  include/linux/security.h            |  6 ++++++
>>>  security/security.c                 | 13 +++++++++++++
>> This patch needs to be sent to the linux-security-module list.
>>