linux-kernel - Re: [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47583cb5-d211-407c-8b7e-d79934a90b28@kernel.org>
Date: Wed, 16 Apr 2025 08:34:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Chen <peter.chen@...tech.com>, soc@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, catalin.marinas@....com,
 will@...nel.org, arnd@...db.de, jassisinghbrar@...il.com
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
 maz@...nel.org, kajetan.puchalski@....com,
 Guomin Chen <Guomin.Chen@...tech.com>, Lihua Liu <Lihua.Liu@...tech.com>
Subject: Re: [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox

On 15/04/2025 09:27, Peter Chen wrote:
> From: Guomin Chen <Guomin.Chen@...tech.com>
> 
> Add a dt-binding for the Cixtech Mailbox Controller.
> 
> Reviewed-by: Peter Chen <peter.chen@...tech.com>
> Signed-off-by: Lihua Liu <Lihua.Liu@...tech.com>
> Signed-off-by: Guomin Chen <Guomin.Chen@...tech.com>

You send patches to soc@ AFTER you get community review, not during.
Look again at document I linked some time ago. New files are not sent to
review to soc@.

> ---
> Changes for v3:
> - Replace the direction attribute of the mailbox with the strings "rx" and "tx"
> 
>  .../bindings/mailbox/cix,sky1-mbox.yaml       | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)

That's a completely new file? If you add new patches, mention in the
changelog.

And keep the changelog from the other patchset. What changed here? were
my comments resolved or not?


Best regards,
Krzysztof