linux-kernel - Re: Hitting WARN_ON_ONCE in i2c-designware-common.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_9QRqk_8rTkQVpx@smile.fi.intel.com>
Date: Wed, 16 Apr 2025 09:37:58 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: Luis Oliveira <lolivei@...opsys.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	linux-i2c@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-team <kernel-team@...udflare.com>
Subject: Re: Hitting WARN_ON_ONCE in i2c-designware-common.c

On Tue, Apr 15, 2025 at 02:30:10PM +0200, Jesper Dangaard Brouer wrote:
> On 15/04/2025 14.19, Andy Shevchenko wrote:
> > On Tue, Apr 15, 2025 at 03:17:37PM +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 15, 2025 at 02:03:26PM +0200, Jesper Dangaard Brouer wrote:
> > > > 
> > > > I'm hitting a WARN_ON_ONCE in drivers/i2c/busses/i2c-designware-common.c
> > > > when booting the kernel on our Gen12 hardware.
> > > > 
> > > > I'm using devel kernel net-next at commit 1a9239bb425 (merge tag
> > > > 'net-next-6.15').
> > > > 
> > > > I assume you want this report.
> > > > 
> > > > Maybe it is not a critical error(?)
> > > > ... looking the comment in the function:
> > > 
> > > Have you forgotten to compile in the drivers/acpi/acpi_apd.c?
> 
> I have double checked that drivers/acpi/acpi_apd.o is compiled.

Hmm... But is the function that creates clock is compiled? And does it succeed
(see also my comment about missing error check which you probably want to
 address independently on the affection on this issue).

> > Also that driver has the missing error check in acpi_apd_setup() for
> > clk_register_clkdev().
> 
> Are you saying I'm missing a .config option?

I'm saying that please double check that the clock is provided and AFAICT it
has to be created by the above mentioned module.

-- 
With Best Regards,
Andy Shevchenko