linux-kernel - Re: [PATCH v1 1/4] dt-bindings: display: panel: Document Renesas R61307 based DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPVz0n0qTUqt+JEy0R4-=jJLgVRcNwwe0k2jTd=hcLxSoAFG_g@mail.gmail.com>
Date: Wed, 16 Apr 2025 09:40:41 +0300
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: display: panel: Document Renesas
 R61307 based DSI panel

ср, 16 квіт. 2025 р. о 00:55 Rob Herring <robh@...nel.org> пише:
>
> On Sun, Apr 13, 2025 at 02:23:58PM +0300, Svyatoslav Ryhel wrote:
> > R61307 is liquid crystal driver for high-definition amorphous silicon
> > (a-Si) panels and is ideal for tablets and smartphones.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> >  .../display/panel/renesas,r61307.yaml         | 93 +++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> > new file mode 100644
> > index 000000000000..a98d2d2e02d2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
> > @@ -0,0 +1,93 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/renesas,r61307.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R61307 based DSI Display Panel
> > +
> > +maintainers:
> > +  - Svyatoslav Ryhel <clamor95@...il.com>
> > +
> > +description:
> > +  The Renesas R61307 is a generic DSI Panel IC used to control LCD panels.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +        # KOE/HITACHI TX13D100VM0EAA 5.0" XGA TFT LCD panel
> > +      - hit,tx13d100vm0eaa
> > +      - koe,tx13d100vm0eaa
>
> Usuually when the display IC is known, there's a fallback compatible for
> it. Then 'renesas' vendor prefix on the properties makes more sense.
>

Acknowledged, thank you.

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vcc-supply:
> > +    description: Regulator for main power supply.
> > +
> > +  iovcc-supply:
> > +    description: Regulator for 1.8V IO power supply.
> > +
> > +  backlight: true
> > +
> > +  renesas,gamma:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      0 - disabled
> > +      1-3 - gamma setting A presets
> > +    enum: [0, 1, 2, 3]
> > +
> > +  renesas,inversion:
> > +    type: boolean
> > +    description: switch between line and column inversion. The line
> > +      inversion is set by default.
>
> The property name is odd since there's always some sort of
> inversion. Perhaps renesas,column-inversion?
>

Acknowledged, thank you.

> > +
> > +  renesas,contrast:
> > +    type: boolean
> > +    description: digital contrast adjustment
>
> I would have expected contrast to be more than boolean. Is this
> something any a-Si panel would support or somehow Renesas specific?
>

ATM there is only one known set of commands regards digital contrast
adjustment and it application is optional, hence bool. However, panel
which my device uses refuses to work properly without this
configuration applied. Since there is no specific programming guide
regards this IC I cannot say for sure if this is panel specific or a
Renesas IC feature. When/if there will be any additional data
available this property can by adjusted or dropped.

> > +
> > +  reset-gpios: true
> > +  port: true
> > +
> > +required:
> > +  - compatible
> > +  - port
> > +  - backlight
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@1 {
> > +            compatible = "koe,tx13d100vm0eaa";
> > +            reg = <1>;
> > +
> > +            reset-gpios = <&gpio 176 GPIO_ACTIVE_LOW>;
> > +
> > +            renesas,gamma = <3>;
> > +            renesas,inversion;
> > +            renesas,contrast;
> > +
> > +            vcc-supply = <&vcc_3v0_lcd>;
> > +            iovcc-supply = <&iovcc_1v8_lcd>;
> > +
> > +            backlight = <&backlight>;
> > +
> > +            port {
> > +                panel_in: endpoint {
> > +                    remote-endpoint = <&dsi_out>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +
> > +...
> > --
> > 2.43.0
> >