linux-kernel - Re: [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01872a8318e2c87b124631822785d3ea494030f0.camel@mediatek.com>
Date: Wed, 16 Apr 2025 06:44:37 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "jie.qiu@...iatek.com"
	<jie.qiu@...iatek.com>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"simona@...ll.ch" <simona@...ll.ch>, "mripard@...nel.org"
	<mripard@...nel.org>, Jitao Shi (石记涛)
	<jitao.shi@...iatek.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "kernel@...labora.com" <kernel@...labora.com>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	Lewis Liao (廖柏鈞) <Lewis.Liao@...iatek.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, TommyYL Chen (陳彥良)
	<TommyYL.Chen@...iatek.com>, Ives Chenjh (陳俊弘)
	<Ives.Chenjh@...iatek.com>, "airlied@...il.com" <airlied@...il.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Jason-JH Lin (林睿祥)
	<Jason-JH.Lin@...iatek.com>, "junzhi.zhao@...iatek.com"
	<junzhi.zhao@...iatek.com>
Subject: Re: [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add
 common probe function

On Tue, 2025-04-15 at 12:48 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Il 15/04/25 12:43, AngeloGioacchino Del Regno ha scritto:
> > In preparation for adding a new driver for the HDMI TX v2 IP,
> > split out the functions that will be common between the already
> > present mtk_hdmi (v1) driver and the new one.
> > 
> > Since the probe flow for both drivers is 90% similar, add a common
> > probe function that will be called from each driver's .probe()
> > callback, avoiding lots of code duplication.
> > 
> > Reviewed-by: CK Hu <ck.hu@...iatek.com>
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > ---
> >   drivers/gpu/drm/mediatek/Kconfig           |   11 +-
> >   drivers/gpu/drm/mediatek/Makefile          |    1 +
> >   drivers/gpu/drm/mediatek/mtk_hdmi.c        |  538 +-----
> >   drivers/gpu/drm/mediatek/mtk_hdmi.c.orig   | 1769 ++++++++++++++++++++
> >   drivers/gpu/drm/mediatek/mtk_hdmi_common.c |  422 +++++
> >   drivers/gpu/drm/mediatek/mtk_hdmi_common.h |  188 +++
> >   6 files changed, 2398 insertions(+), 531 deletions(-)
> >   create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.c.orig
> 
> CK, I just acknowledged that a .orig file slipped through and got sent out with
> this patch....
> 
> Truly sorry for that, can you please fix that up while applying without having me
> send another patchbomb?

I would drop mtk_hdmi.c.orig when apply this patch.

Regards,
CK

> 
> Many thanks,
> Angelo
> 
> >   create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> >   create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.h
> >