linux-kernel - Re: [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_9V9x_YBfxiCh1w@smile.fi.intel.com>
Date: Wed, 16 Apr 2025 10:02:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Jai Luthra <jai.luthra@...asonboard.com>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct
 device

On Wed, Apr 16, 2025 at 08:55:27AM +0200, Wolfram Sang wrote:
> On Mon, Apr 14, 2025 at 01:01:55PM +0300, Andy Shevchenko wrote:
> > In order to make the underneath API easier to change in the future,
> > prevent users from dereferencing fwnode from struct device.
> > Instead, use the specific device_set_node() API for that.
> > 
> > Tested-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> > Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> I'll check this patch later today. Rest of the series looks good to me
> already.

Note, I'm planning to send a v5 shortly with the style fixes and commit
messages as you suggested.

-- 
With Best Regards,
Andy Shevchenko