linux-kernel - Re: [PATCH] ASoC: Intel: sof_sdw: Add NULL check in asoc_sdw_rt_dmic_rtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1890bbe-183c-43ee-b866-936f9a7e4801@web.de>
Date: Wed, 16 Apr 2025 09:19:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Chenyuan Yang <chenyuan0y@...il.com>, linux-sound@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Chao Song <chao.song@...ux.intel.com>, Jaroslav Kysela <perex@...ex.cz>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Peter Zijlstra <peterz@...radead.org>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Takashi Iwai <tiwai@...e.com>, Vijendar Mukunda <Vijendar.Mukunda@....com>
Subject: Re: [PATCH] ASoC: Intel: sof_sdw: Add NULL check in
 asoc_sdw_rt_dmic_rtd_init()

> mic_name returned by devm_kasprintf() could be NULL.
> Add a check for it.

Was this patch also supported by the source code analysis tool “KNighter”?


…
> +++ b/sound/soc/sdw_utils/soc_sdw_rt_dmic.c
> @@ -29,6 +29,8 @@ int asoc_sdw_rt_dmic_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc_da
>  		mic_name = devm_kasprintf(card->dev, GFP_KERNEL, "rt715-sdca");
>  	else
>  		mic_name = devm_kasprintf(card->dev, GFP_KERNEL, "%s", component->name_prefix);
…

How do you think about to use the function “devm_kstrdup” in one if branch instead
(by another update step)?
https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/base/devres.c#L958-L965

Regards,
Markus