linux-kernel - Re: [PATCH v5 09/14] iio: adc: ad7768-1: Add GPIO controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY0VAkW3v5mBzxz5u5RfLv4zpj5sy-zpx8Ma9+0=8qQfQ@mail.gmail.com>
Date: Wed, 16 Apr 2025 09:35:49 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>, lars@...afoo.de, Michael.Hennerich@...log.com, 
	marcelo.schmitt@...log.com, jic23@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, marcelo.schmitt1@...il.com, 
	brgl@...ev.pl, lgirdwood@...il.com, broonie@...nel.org, jonath4nns@...il.com, 
	dlechner@...libre.com, Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v5 09/14] iio: adc: ad7768-1: Add GPIO controller support

Hi Jonathan,

thanks for your patch!

On Fri, Apr 11, 2025 at 5:58 PM Jonathan Santos
<Jonathan.Santos@...log.com> wrote:

> +static void ad7768_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
> +{
(...)
> +       st->gpiochip = (struct gpio_chip) {
> +               .label = "ad7768_1_gpios",
> +               .base = -1,
> +               .ngpio = 4,
> +               .parent = &st->spi->dev,
> +               .can_sleep = true,
> +               .direction_input = ad7768_gpio_direction_input,
> +               .direction_output = ad7768_gpio_direction_output,
> +               .get = ad7768_gpio_get,
> +               .set = ad7768_gpio_set,

Due to refactorings going on in the .set calls please switch this to use
the new .set_rv() callback that return an integer (errorcode) on failure.

Yours,
Linus Walleij