linux-kernel - Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00619904-9111-4e75-9ff7-1494ed299f9b@sk.com>
Date: Wed, 16 Apr 2025 16:37:52 +0900
From: Honggyu Kim <honggyu.kim@...com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Rakie Kim <rakie.kim@...com>
Cc: kernel_team@...ynix.com, akpm@...ux-foundation.org, gourry@...rry.net,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
 joshua.hahnjy@...il.com, dan.j.williams@...el.com,
 ying.huang@...ux.alibaba.com, david@...hat.com, osalvador@...e.de,
 yunjeong.mun@...com
Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted
 interleave



On 4/16/2025 1:04 PM, Honggyu Kim wrote:
> Hi Jonathan,
> 
> Thanks for reviewing our patches.
> 
> I have a few comments and the rest will be addressed by Rakie.
> 
> On 4/16/2025 1:00 AM, Jonathan Cameron wrote:
>> On Tue, 8 Apr 2025 16:32:42 +0900
>> Rakie Kim <rakie.kim@...com> wrote:
[...snip...]
>>> @@ -3495,35 +3508,77 @@ static const struct kobj_type wi_ktype = {
>>>   static int sysfs_wi_node_add(int nid)
>>>   {
>>> -    struct iw_node_attr *node_attr;
>>> +    int ret = 0;
>>
>> Trivial but isn't ret always set when it is used? So no need to initialize
>> here.
> 
> If we don't initialize it, then this kind of trivial fixup might be needed later
> so I think there is no reason not to initialize it.
> https://lore.kernel.org/mm-commits/20240705010631.46743C4AF07@smtp.kernel.org

Ah.  This is a different case.  Please ignore this.

> 
>>
>>>       char *name;
>>> +    struct iw_node_attr *new_attr = NULL;
>>
>> This is also always set before use so I'm not seeing a
>> reason to initialize it to NULL.
> 
> Ditto.

Please ignore this too.

Thanks,
Honggyu