linux-kernel - Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/7/inRyIxCIDOKz@dev-ushankar.dev.purestorage.com>
Date: Tue, 15 Apr 2025 18:53:30 -0600
From: Uday Shankar <ushankar@...estorage.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Ming Lei <ming.lei@...hat.com>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

On Tue, Apr 15, 2025 at 06:41:10PM -0600, Caleb Sander Mateos wrote:
> The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to
> Y so task_work_add() can be used to dispatch I/O, improving performance.
> However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill
> queuing request by task_work_add"). So remove this paragraph from the
> config help text.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Uday Shankar <ushankar@...estorage.com>

> ---
>  drivers/block/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 2551ebf88dda..e48b24be45ee 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -386,16 +386,10 @@ config BLK_DEV_UBLK
>  	  io_uring based userspace block driver. Together with ublk server, ublk
>  	  has been working well, but interface with userspace or command data
>  	  definition isn't finalized yet, and might change according to future
>  	  requirement, so mark is as experimental now.
>  
> -	  Say Y if you want to get better performance because task_work_add()
> -	  can be used in IO path for replacing io_uring cmd, which will become
> -	  shared between IO tasks and ubq daemon, meantime task_work_add() can
> -	  can handle batch more effectively, but task_work_add() isn't exported
> -	  for module, so ublk has to be built to kernel.
> -
>  config BLKDEV_UBLK_LEGACY_OPCODES
>  	bool "Support legacy command opcode"
>  	depends on BLK_DEV_UBLK
>  	default y
>  	help
> -- 
> 2.45.2
>