linux-kernel - Re: [PATCH] crypto: skcipher - Realign struct skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_9jRZgQJQgNtk0b@gondor.apana.org.au>
Date: Wed, 16 Apr 2025 15:59:01 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Biggers <ebiggers@...gle.com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: skcipher - Realign struct skcipher_walk to save
 8 bytes

On Fri, Apr 11, 2025 at 09:20:51PM +0200, Thorsten Blum wrote:
> Reduce skcipher_walk's struct size by 8 bytes by realigning its members.
> 
> pahole output before:
> 
>   /* size: 120, cachelines: 2, members: 13 */
>   /* sum members: 108, holes: 2, sum holes: 8 */
>   /* padding: 4 */
>   /* last cacheline: 56 bytes */
> 
> and after:
> 
>   /* size: 112, cachelines: 2, members: 13 */
>   /* padding: 4 */
>   /* last cacheline: 48 bytes */
> 
> No functional changes intended.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  include/crypto/internal/skcipher.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt