linux-kernel - Re: [PATCH 1/4] crypto: img-hash - use API helpers to setup fallback request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_9-pJ_lXA3AzjGC@Red>
Date: Wed, 16 Apr 2025 11:55:48 +0200
From: Corentin Labbe <clabbe.montjoie@...il.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Ovidiu Panait <ovidiu.panait.oss@...il.com>,
	linux-crypto@...r.kernel.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] crypto: img-hash - use API helpers to setup fallback
 request

Le Wed, Apr 16, 2025 at 03:55:39PM +0800, Herbert Xu a écrit :
> On Mon, Apr 07, 2025 at 03:36:01PM +0300, Ovidiu Panait wrote:
> > Rather than setting up the fallback request by hand, use
> > ahash_request_set_callback() and ahash_request_set_crypt() API helpers
> > to properly setup the new request.
> > 
> > This also ensures that the completion callback is properly passed down
> > to the fallback algorithm, which avoids a crash with async fallbacks.
> > 
> > Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>
> > ---
> >  drivers/crypto/img-hash.c | 41 ++++++++++++++++++++++-----------------
> >  1 file changed, 23 insertions(+), 18 deletions(-)
> 
> Patches 1-2,4 applied.  Thanks.

You can merge sun8i-ss patch, it is ok.

Could you add my tested-by on rk3328 patch also ?

Thanks